Skip to content

[webhooks] signature header fallback #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
capcom6 merged 1 commit into from
Aug 27, 2026
Merged

[webhooks] signature header fallback #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions internal/server/docs/docs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1942,6 +1942,13 @@ const docTemplate = `{
"schema": {
"$ref": "#/definitions/webhooks.PushEvent"
}
},
{
"type": "string",
"description": "BitBucket signature header",
"name": "X-Hub-Signature",
"in": "header",
"required": true
}
],
"responses": {
Expand Down
15 changes: 10 additions & 5 deletions internal/server/webhooks/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,21 @@ func (h *Handler) Register(r fiber.Router) {
// @Tags Webhooks
// @Accept json
// @Produce json
// @Param body body PushEvent true "BitBucket push event payload"
// @Success 202 {object} webhooks.ProcessResult
// @Failure 400 {object} fiberfx.ErrorResponse
// @Failure 401 {object} fiberfx.ErrorResponse
// @Param body body PushEvent true "BitBucket push event payload"
// @Param X-Hub-Signature header string true "BitBucket signature header"
// @Success 202 {object} webhooks.ProcessResult
// @Failure 400 {object} fiberfx.ErrorResponse
// @Failure 401 {object} fiberfx.ErrorResponse
// @Router /webhooks/bitbucket/push [post]
//
// handlePush processes a BitBucket push event webhook.
func (h *Handler) handlePush(c *fiber.Ctx) error {
rawBody := c.BodyRaw()
sigHeader := c.Get("X-Hub-Signature-256")

sigHeader := c.Get("X-Hub-Signature")
if sigHeader == "" {
sigHeader = c.Get("X-Hub-Signature-256")
}

if err := h.svc.VerifyPushEvent(rawBody, sigHeader); err != nil {
if errors.Is(err, webhooks.ErrInvalidSignature) {
Expand Down
Loading