Avoid Buffer in testEcc - #35
Merged
Merged
Conversation
Use uint8array-tools for hex vectors and byte equality so testEcc stays on Uint8Array. This finishes the Buffer removal started in bitcoinjs#22 and avoids requiring Buffer polyfills.
Member
|
Please publish a patch release when you get some time. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #22 moved ecpair toward Uint8Array and away from Buffer, but testEcc still used Buffer for hex vectors and equality checks. This replaces those leftovers with uint8array-tools so testEcc no longer needs Buffer or Buffer polyfills. Tests: npm test