Repository navigation
team-setup: make @get-bb/plugin-sdk a runtime dependency - #103
Merged
trotterdylan merged 1 commit intoOct 26, 2026
Merged
Conversation
The Figma step (BB-67, #97) imports experimental_sanitizeInheritedChildProcessEnv from @get-bb/plugin-sdk/host in figma.ts, which is part of the host bundle. The bb-server image installs each plugin with `npm ci --omit=dev`, and the SDK was only a devDependency, so the host build failed on every developer's server: figma.ts:21:92: ERROR: "@get-bb/plugin-sdk/host" is not installed for this plugin (no node_modules/@get-bb/plugin-sdk) and the plugin showed "Failed: The plugin couldn't start" under Settings. stewards and multi-repo already list the SDK under dependencies for the same reason; team-setup now does too. The lockfile also picks up the engines bump from package.json that had not been regenerated. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every developer's Team setup plugin shows Failed: The plugin couldn't start under Settings.
bb plugin listgives the cause:The Figma step (BB-67, #97) added that import to the host bundle. The
bb-serverimage installs each plugin withnpm ci --omit=dev, and team-setup listed the SDK only as a devDependency, so it was missing in the image. CI did not catch it because CI installs devDependencies.Fix
Move
@get-bb/plugin-sdktodependencies, as stewards and multi-repo already do, and regenerate the lockfile (which also picks up the engines bump that was never regenerated).Verified:
npm ci --omit=dev --legacy-peer-depson a clean copy now installs the SDK andbb plugin buildproduces the server, app and host bundles. Typecheck and the 68 tests pass.Lane
No-review: a narrow fix that makes the plugin start as it was meant to; no behaviour change.
Merging moves the
bb-serverpin, builds a new image and stages a restart for every developer's server.🤖 Generated with Claude Code