This repository was archived by the owner on May 26, 2026. It is now read-only.
Conversation
2 tasks
7e23594 to
e8b581d
Compare
e8b581d to
fbd80cb
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Jtx Board iCalendar generation to work with ical4j 4.x immutable PropertyList behavior, preventing silently dropped exception properties and missing alarm properties when exporting VTODO/VJOURNAL.
Changes:
- Reworks VALARM construction to build a fresh
PropertyListfrom collected alarm properties. - Fixes recurring exception export by re-assigning the modified
propertyListonto the exception component. - Adds instrumented tests to validate exception
UID/RECURRENCE-IDand basic VALARM property presence.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| lib/src/main/kotlin/at/bitfire/ical4android/JtxICalObject.kt | Adapts alarm and recurrence-exception serialization to immutable ical4j list semantics. |
| lib/src/androidTest/kotlin/at/bitfire/ical4android/JtxICalObjectTest.kt | Adds regression tests for exception properties and alarm property generation. |
sunkup
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ical4j 4.x changed its collection types (
PropertyList,ComponentList,ParameterList) to be immutable — operations likeadd()andremove()return a new instance instead of modifying in place:Several places in
JtxICalObject.ktwere discarding those return values, silently losing data (empty VTODO exceptions → HTTP 415 from server, dropped alarms).This PR
alarmProps),