Misc updates for latest ESP-IDF compatibility - #45
Open
guruprasadah wants to merge 16 commits into
Open
Conversation
- APLL: wrap the split rtc_clk_apll_enable(bool) + rtc_clk_apll_coeff_set() API (ESP-IDF >= 5.0) behind the historical 5-argument signature so the existing call sites compile unchanged. - LEDC: use the new pin-based ledcAttach()/ledcWrite(pin, ...) API on Arduino-ESP32 3.x, falling back to ledcSetup()/ledcAttachPin() on older cores. - DAC: use DAC_CHAN_0 instead of the deprecated DAC_CHANNEL_1 alias. - ISR: cast the lldesc_t buf pointer to volatile void* to fix the const-volatile conversion error, and drop IRAM_ATTR from the video_isr forward declaration to avoid a conflicting section attribute warning. - Silence -Wformat (%d for an int) and -Wxor-used-as-pow (hex constants) warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Assisted code fix that updates certain function calls (names, arguments) with preprocessor safeguards for backwards compatibility.