Skip to content

[BWS] Chore: unnecessary simplexGetEvents endpoint removed #4226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gamboster wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −62
Open

[BWS] Chore: unnecessary simplexGetEvents endpoint removed #4226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions packages/bitcore-wallet-service/src/externalservices/simplex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,34 +248,4 @@ export class SimplexService {
);
});
}

simplexGetEvents(req): Promise<any> {
return new Promise((resolve, reject) => {
if (!config.simplex) return reject(new Error('Simplex missing credentials'));
if (!req.env || (req.env != 'sandbox' && req.env != 'production'))
return reject(new Error("Simplex's request wrong environment"));

const API = config.simplex[req.env].api;
const API_KEY = config.simplex[req.env].apiKey;
const headers = {
'Content-Type': 'application/json',
Authorization: 'ApiKey ' + API_KEY
};

this.request.get(
API + '/wallet/merchant/v2/events',
{
headers,
json: true
},
(err, data) => {
if (err) {
return reject(err.body ? err.body : null);
} else {
return resolve(data.body ? data.body : null);
}
}
);
});
}
}
15 changes: 1 addition & 14 deletions packages/bitcore-wallet-service/src/lib/routes/services.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ function respondWithAuthServer(req, res, context: RouteContext, handler: RouteHa
}

export function registerServiceRoutes(router: express.Router, context: RouteContext) {
const { getServerWithAuth, setPublicCache, returnError } = context;
const { setPublicCache } = context;

const transakCorsOptions = {
origin: (origin, cb) => {
Expand Down Expand Up @@ -399,19 +399,6 @@ export function registerServiceRoutes(router: express.Router, context: RouteCont
});
});

router.get('/v1/service/simplex/events', (req, res) => {
getServerWithAuth(req, res, server => {
Promise.resolve()
.then(() => server.externalServices.simplex.simplexGetEvents({ env: req.query.env }))
.then(response => {
res.json(response);
})
.catch(err => {
returnError(err ?? 'unknown', res, req);
});
});
});

router.post('/v1/service/thorswap/supportedChains', (req, res) => {
respondWithPublicServer(req, res, context, server => {
return server.externalServices.thorswap.thorswapGetSupportedChains(req);
Expand Down
18 changes: 0 additions & 18 deletions packages/bitcore-wallet-service/test/integration/externalservices/simplex.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,22 +363,4 @@ describe('Simplex integration', () => {
}
});
});

describe('#simplexGetEvents', () => {
beforeEach(() => {
req = {
env: 'production'
};

fakeRequest = {
get: (_url, _opts, _cb) => { return _cb(null, { body: {} }); },
};
server.externalServices.simplex.request = fakeRequest;
});

it('should work properly if req is OK', async () => {
const data = await server.externalServices.simplex.simplexGetEvents(req);
should.exist(data);
});
});
});