ci: rename workflow ci→check on xcodeproject-v2 to match master#337
Open
Badlazzor wants to merge 4 commits into
Open
ci: rename workflow ci→check on xcodeproject-v2 to match master#337Badlazzor wants to merge 4 commits into
Badlazzor wants to merge 4 commits into
Conversation
…nge-workdir The unified step CI app (48fa8fbee698622c) invokes `bitrise run check` on every PR. xcodeproject-v2 still had the older `ci` name, so every PR targeting this branch failed at workflow lookup with "specified Workflow (check) does not exist". Bring bitrise.yml in line with master: rename `ci` → `check` and add the trailing `change-workdir: ..` step that integration_test uses on master. Unblocks #335 (and any other open PR off this branch). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
benbitrise
approved these changes
Jul 7, 2026
Fix pre-existing revive/staticcheck/gosimple issues surfaced when the CI workflow rename exposed them:
- add doc comments on exported XcodeProj + methods and workspace.NewFromFile
- io/ioutil.WriteFile → os.WriteFile (plist.go, recreate_schemes.go, xcodeproj.go)
- for true {} → for {} + drop unreachable trailing return in resolve()
- unused const invalid → blank identifier (preserve iota offset)
- schemes_test.go: assert err from Schemes()
- codesign tests: t.Errorf/Fatalf(err.Error()) → t.Error/Fatal(err)
- example_test.go: swallow projects with _ to satisfy SA4010
- resources_build_phase.go: explicit _ for optional entryPath
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The unified step CI app (
48fa8fbee698622c) invokesbitrise run checkon every PR. Thexcodeproject-v2branch still has the olderciname, so every PR targeting it dies at workflow lookup:```
specified Workflow (check) does not exist
```
Changes
bitrise.yml: renameci→check(matches master).change-workdir: ..step inintegration_test(also matches master — keeps the v2 branch in lock-step with mainline CI config).Context
Spotted while triaging #335 under STEP-2426. Every open PR off
xcodeproject-v2is currently red on infra, not code.Test plan
checksuccessfully.🤖 Generated with Claude Code