Repository navigation
Rollout: upgrade Effect and Foldkit - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the two selected WorldVM items,
effect-latestandfoldkit-latest, from a fresh branch atorigin/main(4ce51b9). The previous rollout PR (#41) is already merged.Versions
effect,@effect/platform-node,@effect/platform-node-shared,@effect/sql-d1,@effect/sql-pg,@effect/sql-sqlite-do,@effect/sql-sqlite-node,@effect/vitest@effect/platform-browser(new required Foldkit peer)foldkit,@foldkit/ui@foldkit/vite-pluginAll locked resolutions match these exact targets. Existing public Effect peers use the shared catalog and pack as exact
4.0.3peers. No unused Foldkit companions were added.Required companion upgrades: Vitest 4.1.11 → 5.0.4 (
@effect/vitestrequires Vitest 5), Cloudflare test plugin 1.1.4 → 1.4.0 (Vitest 5 support), Workers types 5.20260904.1 → 5.20261006.1 (Wrangler's peer minimum), and Alchemy 2.0.0-beta.76 → beta.80 (stable Effect imports). These replace incompatible integrations rather than forcing their transitive Effect versions.Migration and compatibility
Base64Urlfromeffect/encodingand capitalized Config/CLI constructors..makeconstructors rather than overwriting Effect's getter. Preserve single-argumentunsafehelpers; add constructor validation regressions.parseOptionsannotations with explicit property-name checks that preserve closed structs, nested decoding and HTTP payload validation. Add regressions for nested, empty and symbol-keyed structs and unknown HTTP keys. Refresh OpenAPI snapshots for stable schema generation, including closed-key constraints and internally consistent component references.node:sqlite; remove the obsolete native-addon override/rebuild from the clean consumer test.Foldkit's published metadata still declares exact Effect/platform-browser 4.0.0 peers, and its Vite plugin pins Node adapters to 4.0.0. The exception is restricted to
foldkit@0.168.0,@foldkit/ui@0.168.0, and@foldkit/vite-plugin@0.27.1, allowing only 4.0.3 via package-specificpeerDependencyRules.allowedVersions. Only the plugin's two adapter dependencies are overridden to 4.0.3. The browser adapter is explicitly catalog-pinned in the root/docs workspace and dashboard. No global peer-check bypass or Effect override was added. The strict frozen install, dashboard tests, production builds and browser tests validate this combination. The exception and its removal condition are documented in CONTRIBUTING.md; reassess it when upgrading Foldkit again. See Foldkit's release notes and pnpm's scoped peer exceptions.Validation
Node 24.14.1 and pinned pnpm 10.11.0:
pnpm install --frozen-lockfileandpnpm install --frozen-lockfile --strict-peer-dependencies: passed, no peer warnings.pnpm check: passed (formatting, lint, all 27 type/build prerequisite tasks, 14 checked Markdown snippets, generated outputs, unit/SQLite/workerd tests, package and dashboard builds, VitePress build and generated llms structure/local links).pnpm pack:check: passed, 10 tarballs plus a clean TypeScript/runtime/CLI consumer with no dependency overrides.pnpm test:e2e --workers=2: all 13 Chromium tests passed, covering the standalone dashboard, embedded explorer, docs homepage/themes/mobile and interactive playground.PG_TEST_URL=postgresql://triplex_test@127.0.0.1:55432/triplex_test pnpm test:postgres:integration: all 20 passed against a disposable local PostgreSQL 17.10 database. The VM has no Docker; the existing URL fixture runs the same corpus without containers.pnpm --filter triplex-stress stress-test:smoke: 13 passed, 1 intentionally skipped (zero update rounds), 152.36 seconds for 10,000 entities. The two-variable join took 57.3 seconds; performance assertions are disabled by the existing smoke script.Native FoundationDB integration was not run: it needs the external native client/service, and no FoundationDB-specific implementation changed. Provider deployment was not exercised. Repository settings and unrelated template items are unchanged.
Final status: selected upgrades implemented and required validation passed; ready for review. No deployment, publication or merge performed.
Open workspace in Conductor