Repository navigation
fix(publish): optional registry login for image SBOMs - #5
Merged
Merged
Conversation
anchore/sbom-action cannot pull private images without credentials, so every tag release with private images failed in image-sbom. Add a registry-token secret plus registry and registry-username inputs, and log in only when the token is provided so public callers are unchanged.
en0f
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The shared
publish.ymlimage-sbomjob can log in to a registry before running anchore/sbom-action.registry-token, plus inputsregistry(defaultdocker.io) andregistry-username.registry-tokenis passed, so public-image callers are unchanged.Why
image-sbomnever logged in, so it could not pull private images. Every tag release of bbot-enterprise (privatebbot-enterprise-backendandbbot-enterprise-frontendon Docker Hub) would create the release and then fail both SBOM legs, leaving the run red and the image SBOMs unattached. Found in en0f's review of bbot-enterprise#268.Validation
publish.ymlparses (yaml.safe_load). actionlint is not installed locally.registry-usernameandregistry-tokenand is pinned to CLA main de82726. After this merges, #268 repins to the merge commit and the first tag release is the end-to-end check.Refs blacklanternsecurity/bbot-enterprise#150
Refs blacklanternsecurity/bbot-enterprise#268