Repository navigation
fix(ci): drop the auto-merge job's own check by run id, not workflow name - #7
Open
singlerider wants to merge 1 commit into
Open
singlerider wants to merge 1 commit into
singlerider wants to merge 1 commit into
Conversation
…name The wait loop filtered its own check out with `.workflow != github.workflow`. GitHub names a workflow entity from the default branch, so a caller that lives only on `dev` (bbot) is registered under its file path while `github.workflow` is the `name:` key. The filter never matched, the job saw itself pending, and every dependabot run sat until the 180 minute timeout. Filter on `GITHUB_RUN_ID` against each check's link instead. In a called workflow that is the caller's run id, which is what the check link carries, so it survives renames and callers missing from the default branch. Closes #6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
dependabot-auto-merge.ymlfilters its own check out of the wait loop byGITHUB_RUN_IDmatched against each check's link, instead of.workflow != github.workflow.Why
GitHub names a workflow entity from the default branch. bbot's caller lives only on
dev, so its check reportsworkflowas.github/workflows/dependabot-auto-merge.ymlwhilegithub.workflowisDependabot auto-merge. The self-filter never matched, the job saw itself pending, and every dependabot run sat untiltimeout-minutes: 180and was cancelled. In a called workflowGITHUB_RUN_IDis the caller's run id, which is what the check link carries, so this survives renames and callers missing from the default branch.Validation
Real checks from blacklanternsecurity/bbot#3490, where run 37648243807 is the stuck auto-merge job:
The old filter kept its own pending check; the new one drops exactly that check and would proceed to merge. Callers need their pin moved to the merge commit to pick this up.
Closes #6