Repository navigation
fix(release): cut prerelease tags from dev - #8
Open
singlerider wants to merge 1 commit into
Open
singlerider wants to merge 1 commit into
singlerider wants to merge 1 commit into
Conversation
release.sh required every tag to be cut from the default branch. In repositories whose default branch is stable, the documented prerelease path (vX.Y.Z-rc.N from dev) died with "not trunk 'stable'". Tags matching -rc.N now require a clean dev checkout equal to the remote dev. Release tags still require the default branch. Verified in a scratch repo: rc on dev reaches the confirm prompt, rc on stable and a release on dev or a detached HEAD are refused. Refs blacklanternsecurity/bbot-enterprise#139
en0f
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
release.shcuts-rc.Ntags fromdevand release tags from the default branch.-rc.Nrequires a cleandevcheckout equal to<remote>/dev.Why
The script required every tag to come from the default branch. In repos whose default branch is
stable(bbot), the documented prerelease path,release.sh vX.Y.Z-rc.Nfromdev, died with "not trunk 'stable'". Raised by en0f and liquidsec on blacklanternsecurity/bbot#3355. With publishing tag-only, an rc tag fromdevis the only thing that moves the:devimage, so this path has to work.Validation
stable: rc tag ondevreaches the confirm prompt. rc onstable, a release ondev, and a detached HEAD are refused. A release onstablereaches the prompt.uvx --from shellcheck-py shellcheck scripts/release.sh: clean.pytest: 16 passed.After merge, bbot#3355 repins to the merge commit.
Refs blacklanternsecurity/bbot-enterprise#139
Refs blacklanternsecurity/bbot#3355