Repository navigation
Bump ruff from 0.15.2 to 0.17.0 - #130
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.15.2 to 0.17.0. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.15.2...0.17.0) --- updated-dependencies: - dependency-name: ruff dependency-version: 0.17.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
en0f
left a comment
There was a problem hiding this comment.
PR #130 is blocked, but the ruff bump isn’t the cause. All three Tests jobs (lint, test 3.13, test 3.14) fail at uv sync --dev, before ruff or the tests ever run. The package won’t build at all:
ValueError: Dependency #2 of field project.dependencies cannot be a direct reference
unless field tool.hatch.metadata.allow-direct-references is set to true
Cause: this started on master when the code switched to the BLS Impacket fork (#128). The dependency now points straight at git+https://github.com/blacklanternsecurity/impacket, and hatchling refuses to build with that unless it’s explicitly allowed. Every PR since then fails the same way (#125, #117, #127, #128). The ruff 0.16.10 bump (#124) passed before that change landed.
Fix: add this to pyproject.toml on master, then rebase this PR:
toml
[tool.hatch.metadata]
allow-direct-references = true
After that: the ruff check and format steps were skipped, so nobody has actually run ruff 0.17.0 on this code yet. Wait for lint to go green after the rebase before merging. A minor-version bump can bring new rules that fail.
The diff itself (only uv.lock) has nothing broken in it.
|
Superseded by #131. |
Bumps ruff from 0.15.2 to 0.17.0.
Release notes
Sourced from ruff's releases.
... (truncated)
Changelog
Sourced from ruff's changelog.
... (truncated)
Commits
5b27c1cBump version to 0.17.0 (#29259)8f362bfIntegrate vendored Unicode names into Ruff88a50d6Revert upstream Unicode loose matching276832aRevert upstream Unicode alias normalization26911caVendor unicode_names2 from upstream27e3797[ruff] Stabilizeos-path-commonprefix(RUF071) (#28764)bbb52c1[flake8-tidy-imports] Stabilizelazy-import-immediately-resolved(`TID255...5aa9cbd[flake8-tidy-imports] Stabilizelazy-import-mismatch(TID254) (#28760)dba1bc8[flake8-import-conventions] Adddatetime as dtas a conventional alias (`...ef23c9cUpdate default and latest Python versions for 3.15 (#28792)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)