Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3532 +/- ##
======================================
+ Coverage 91% 91% +1%
======================================
Files 463 465 +2
Lines 49758 49905 +147
======================================
+ Hits 44890 45037 +147
Misses 4868 4868 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
📊 Performance Benchmark Report
📈 Detailed Results (All Benchmarks)
🎯 Performance Summary✅ No significant performance changes detected (all changes <10%) 🐍 Python Version 3.11.17 |
liquidsec
added a commit
that referenced
this pull request
Oct 17, 2026
en0f
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3510
Adds a
faviconmodule that identifies technologies by the mmh3 hash of their favicon, using the signatures in nuclei-templates'favicon-detect.yaml(MIT, actively maintained, ~700 hashes). Other sources were evaluated: FavFreak and EHole are largely subsets of the same Shodan-derived lineage, and Rapid7 Recog's MD5 set has not been updated since 2024.How it works
HTTP_RESPONSE, emitsTECHNOLOGY.signatures_urlis configurable, e.g. to pin a tag). Matchers in an unrecognized format are skipped with a warning; if nothing parses, the module soft-fails.<link rel="icon">/rel="shortcut icon"hrefs, then/<first path segment>/favicon.icowhen the page is in a subdirectory and declares no icon (apps mounted under a path), then/favicon.ico. Stops at the first match./favicon.icoto/owa/favicon.ico). Skips non-200, empty, and HTML responses (soft 404s).mmh3(base64.encodebytes(body))to match the Shodan/nuclei convention.faviconstripped (e.g.asp.net-faviconbecomesasp.net).TECHNOLOGYevent'surlis the page that triggered the check. The matched hash and the final icon URL are in the event context.Dedup
Presets
web-heavy(notweb) pending a resource evaluation.tech-detect.Related: #3531 (
helpers.download()ignorescache_hrs, so signatures currently refresh weekly instead of daily).