Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## blastdns-2.0 #3533 +/- ##
============================================
- Coverage 91% 91% -0%
============================================
Files 461 461
Lines 49823 49884 +61
============================================
+ Hits 44962 45016 +54
- Misses 4861 4868 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
📊 Performance Benchmark Report
📈 Detailed Results (All Benchmarks)
🎯 Performance Summary! 3 regressions ⚠️
28 unchanged ✅🔍 Significant Changes (>10%)
🐍 Python Version 3.11.17 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every event passes through
dnsresolve, and the web chain passes through it three times (DNS_NAME→OPEN_TCP_PORT→URL/HTTP_RESPONSE). Early in a scan, subdomain modules flood its queue with thousands of newDNS_NAMEs, and because the queue between intercept modules is FIFO, cheap events whose host is already resolved wait behind all of them. The result is a long stretch at the start of a scan where DNS results arrive but no web data does.This splits intercept queues into lanes:
LaneQueue(async_helpers.py): anasyncio.PriorityQueuesubclass where lower lanes are dequeued first and each lane is FIFO. It keeps_queue, soqsize(),maxsizeandnum_queued_eventsbehave as before.BaseInterceptModule.make_intercept_queue()/incoming_lane(event): the queue feeding an intercept module is now built by that module and laned by itsincoming_lane(). The default is a single lane, so other intercept modules are unchanged.dnsresolve.incoming_lane(): events whose host already has a resolvedDNS_NAME/IP_ADDRESSparent (and hostless events) go in lane 0; hosts that still need resolving go in lane 1. The parent lookup is shared withget_dns_parent()via a newfind_dns_parent().Reordering is safe because a fast-lane event's same-host parent has always already passed through the pipeline.
On a
subdomain-enum+httpscan of a real target, the baseline had 1OPEN_TCP_PORTand 0URLs after 120 seconds; with this change it had 147OPEN_TCP_PORTs and 13URLs at 30 seconds, while hostnames resolved at the same rate.