Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3535 +/- ##
=====================================
+ Coverage 91% 91% +1%
=====================================
Files 463 463
Lines 49758 49791 +33
=====================================
+ Hits 44890 44929 +39
+ Misses 4868 4862 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
📊 Performance Benchmark Report
📈 Detailed Results (All Benchmarks)
🎯 Performance Summary! 1 regression ⚠️
30 unchanged ✅🔍 Significant Changes (>10%)
🐍 Python Version 3.11.17 |
liquidsec
added a commit
that referenced
this pull request
Oct 17, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shodan_idb,shodan_enterpriseandcensys_ipemit raw CPE strings as the technology name, e.g.cpe:/a:cloudflare:cloudflareorcpe:2.3:a:apache:tomcat:9.0.50:*:*:*:*:*:*:*. These don't match how any other module names technologies, so they can't be correlated or filtered. They also never trigger technology-driven modules:trajanmatchesjenkins/artifactory, andgitlab_onpremmatches names starting withgitlab.Changes
cpe_product()helper that returns the product name from a CPE 2.2 URI or 2.3 formatted string (lowercased;Nonefor*/-or non-CPE input; handles 2.3's escaped colons).TECHNOLOGYevents get an optionalcpefield.shodan_idb:cpe:/a:jquery:jquery:3.5.1becomestechnology: jquery,cpe: cpe:/a:jquery:jquery:3.5.1.shodan_enterprise: previously emitted each technology up to three times (fromcpe,cpe23andproduct). It now uses the CPE product names (preferringcpe23), and falls back to Shodan'sproductfield only when a service has no CPE.censys_ip: uses the CPE product name, falling back toproductas before.shodan_enterpriseno longer passes aportfield onTECHNOLOGYevents. It wasn't in the event schema, so it was already being dropped.Behavior change
Technology names from these modules change format, e.g.
cpe:/a:microsoft:internet_information_servicesbecomesinternet_information_services. Anything filtering on the old CPE strings should use the newcpefield instead.Tests
test_cpe_product.shodan_idb,shodan_enterpriseandcensys_iptests updated to expect product names and the retained CPE, andshodan_enterprisechecks that no technology name starts withcpe:.