Repository navigation
Give a URL with no path the path / before sending it - #112
Merged
Merged
Conversation
A URL like https://crt.sh?q=example.com went out over HTTP/2 with :path set to ?q=example.com, because hyper builds :path from the URI's path-and-query as written. Servers answer that with a 400. The request URL and redirect targets now get a leading / when they have a host but no path, the same as curl and browsers. Fixes #111
en0f
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #111.
A URL with a query but no path, like
https://crt.sh?q=example.com, went out over HTTP/2 with:pathset to?q=example.com, and servers reject that with a 400. The client now adds the/when it first reads the URL and when it follows a redirect, the same way curl and browsers do.The new tests in
tests/h2_path.rsrun a small local HTTP/2 server that records the:pathit gets, and cover both a direct request and a redirect. To build that server, the TLS test helper can now offer HTTP/2, and hyper'sserverfeature is added as a test-only dependency.