Repository navigation
ci(lint): pin ruff and Rust toolchain, fix resulting lint errors - #94
Closed
singlerider wants to merge 1 commit into
Closed
singlerider wants to merge 1 commit into
singlerider wants to merge 1 commit into
Conversation
The lint job ran an unpinned `pipx install ruff`, which picked up 0.16.9 and failed on 8 pre-existing errors (import order, __slots__ sort, SIM102, SIM201). The Rust job tracked `stable`, whose clippy now denies for_kv_map in src/node/base.rs. Both blocked unrelated PRs such as blacklanternsecurity#92. Pin ruff==0.16.9 in the workflow and dev group, pin Rust 1.97.1 with clippy and rustfmt in rust-toolchain.toml and rust-tests.yml, and fix the errors in source.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #94 +/- ##
===================================
Coverage 100% 100%
===================================
Files 3 3
Lines 604 605 +1
===================================
+ Hits 604 605 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
Folded into #92. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
0.16.9in the lint job and thedevdependency group (uv.lockupdated).1.97.1with clippy and rustfmt in a newrust-toolchain.tomland inrust-tests.yml.__slots__sort, SIM102, SIM201) and the clippyfor_kv_maperror insrc/node/base.rs.Why
#92 fails required
lintandtestchecks for reasons outside its diff: unpinnedpipx install ruffpicked up 0.16.9, and floatingstableclippy addedfor_kv_map. Unblocks #92 for blacklanternsecurity/bbot-enterprise#149.Validation
Before (on
dev):After:
AI-assisted (Jcode).