fix(asset-compiler): bind source validation to opened objects - #131
Merged
blakinio merged 14 commits intoAug 1, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Remediate
OTC2-AUD-003by replacing pathname validation followed by ambientFile::openwith capability-relative, no-follow component traversal and validation on the exact opened source handle.Implemented contract
cap_std::fs::Dircapability;open_dir_nofollow;FollowSymlinks::No;compile_manifest(&Path, &Path)contract and pack format;Security evidence
Dependency review
cap-std = 4.0.2andcap-fs-ext = 4.0.2are pinned. Cargo 1.94.0 generated the lockfile.deny.tomlrecords only exact reviewed capability-graph license and duplicate-version exceptions; advisories, wildcard and source policy remain fail-closed.Decision record
oteryn-client/docs/architecture/decisions/2026-08-01-capability-safe-asset-source-open.mdBoundaries
No workflow, shared PR #23 documentation, external repository or unrelated runtime path remains in the diff.
Exact-head validation
Head
32557716b4455fa7d13094834f20b72ca8470e07passed:30699743934;91368541996: locked metadata, rustfmt, strict Clippy, complete workspace tests and architecture validation;91368542008;30699744005, required job91368653094;mainremainsa16c7e7da32bdc96404845341fd72fbdf4db9bc3.Task
OTC2-20260801-asset-open-integrity-remediation