Skip to content

fix(secrets): complete callback and credential ownership - #136

Merged
blakinio merged 14 commits into
mainfrom
fix/OTC2-20260801-secret-owner-completion
Aug 1, 2026
Merged

fix(secrets): complete callback and credential ownership#136
blakinio merged 14 commits into
mainfrom
fix/OTC2-20260801-secret-owner-completion

Conversation

@blakinio

@blakinio blakinio commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Purpose

Close audited LOW residual OTC2-POST-001 left by the independent post-remediation closure audit.

Implemented contract

  • CallbackAttempt.target is private after bounded accepted construction;
  • external safe Rust callers cannot mutate, take or replace the accepted callback target;
  • a compile_fail API example proves direct target mutation is unavailable;
  • technical-login and identity-security fixtures construct callbacks through CallbackAttempt::new;
  • the callback remains bounded, redacted, non-cloneable and explicitly overwritten on terminal drop;
  • direct non-empty oversized GameEntryCredential input is filled with zeroes before TooLarge returns;
  • accepted credential bytes retain their owned Vec<u8> and existing expiry/one-shot semantics.

Boundaries

Only project-owned initialized bytes are claimed. Allocator, browser, HTTP/TLS, library and operating-system copies remain outside the guarantee. No dependency, manifest, lockfile, workflow, shutdown, asset-open, architecture-policy, endpoint, protocol, shared PR #23 documentation or unrelated UI path remains in the diff.

Exact-head validation

Head 0d6f605a856bc493912ea047d3e782f937ec095f passed:

  • Rust Client run 30703733965;
  • Windows job 91379117193: locked metadata, rustfmt, strict Clippy, full workspace tests including the compile-fail doctest, and real-workspace architecture validation;
  • Supply Chain job 91379117171;
  • repository CI run 30703734074;
  • CI / Required job 91379221271;
  • focused identity, game-session, technical-login integration and identity-security tests during exact fixture migration;
  • exact changed-file review: five declared paths only;
  • comments, reviews and unresolved review threads: none.

Result

OTC2-POST-001 is closed. Relative to the accepted post-W7 package invariant, OTC2-AUD-001 can now be marked CLOSED while retaining the original best-effort project-owned-memory boundary.

Task

OTC2-20260801-secret-owner-completion

@blakinio
blakinio marked this pull request as ready for review August 1, 2026 14:30
@blakinio
blakinio merged commit 78567ea into main Aug 1, 2026
19 checks passed
@blakinio
blakinio deleted the fix/OTC2-20260801-secret-owner-completion branch August 1, 2026 14:32
blakinio added a commit that referenced this pull request Aug 1, 2026
Move the completed secret-owner residual task from active coordination to durable archive after PR #136 merged and all exact-head checks passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant