ci(runtime): continue isolated official Linux client research - #289
ci(runtime): continue isolated official Linux client research#289blakinio wants to merge 461 commits into
Conversation
2096771 to
94dc53d
Compare
|
Track A continuation finding (2026-08-13): semantic, non-pixel login is currently blocked by one isolated runtime dependency, not by the official client UI itself. Existing |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c604dca229
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| TIBIA_TEST_EMAIL: ${{ secrets.TIBIA_TEST_EMAIL }} | ||
| TIBIA_TEST_PASSWORD: ${{ secrets.TIBIA_TEST_PASSWORD }} |
There was a problem hiding this comment.
Declaring the Tibia credentials at job scope exports them to every subprocess in both steps, including the DBus daemons and official client that are deliberately left running after the cleanup trap is disabled. The later unset only changes the workflow shell and cannot remove variables from already-started processes, so subsequent jobs running under the same account can read the credentials from /proc/<pid>/environ; scope them only to the login helper and explicitly remove them from every persistent process launch. docs/agents/TIBIA_RESEARCH_TRACKS.mdL91-L105
Useful? React with 👍 / 👎.
| IFS=: read -r label bin display_no <<<"$spec" | ||
| [[ -n "$bin" && -x "$bin" ]] || { echo TRACK_A_XSERVER_${label}_AVAILABLE=false; continue; } | ||
| display=":$display_no" | ||
| rm -f "/tmp/.X${display_no}-lock" "/tmp/.X11-unix/X${display_no}" 2>/dev/null || true |
There was a problem hiding this comment.
When either display 99 or 100 is already owned by another task on this shared runner, this unconditional removal deletes that task's live X11 socket and lock before starting the probe. The task only declares display :98, so the workflow must reserve unique probe displays and verify their ownership rather than cleaning arbitrary shared display paths. docs/agents/TIBIA_RESEARCH_TRACKS.mdL93-L107
Useful? React with 👍 / 👎.
| if [[ "$new_sha" == "$old_sha" || $stable -lt 3 ]]; then | ||
| echo TRACK_A_UPDATE_FAILED=true | ||
| tail -n 80 "$work/launcher.log" | sed 's/^/TRACK_A_LAUNCHER_LOG=/' || true | ||
| exit 1 |
There was a problem hiding this comment.
If the launcher starts modifying the canonical package but then exits, stalls, or never reaches the stability threshold, this branch exits without restoring the verified backup created above. That can leave the only canonical runtime partially updated while the old client is already stopped, and the next run then fails its initial old-SHA fence, preventing an automatic retry; restore the backup on every unsuccessful update before exiting.
AGENTS.md reference: AGENTS.md:L210-L217
Useful? React with 👍 / 👎.
|
Coordinator disposition: REJECT/SUPERSEDE as a whole-branch integration candidate. Verified at head
This disposition does not discard the branch's unique evidence. The coordinator independently cross-checked and retains the exact-build structural reversible-world transition from run The outgoing-payload artifact from run Canonical promotion ledger: PR #300, |
1 participant
Track
Track A
official-client-re/OTCLIENT-TIBIA-REonly.Scope
Runtime namespace
synology-otclient-01/home/runner/_work/_otclient_tibia_re_state(legacy-image compatibility:/work/_otclient_tibia_re_state):98127.0.0.1:25354OTCLIENT_TIBIA_RE_TRACK=official-client-reValidation
git diff --check: PASSLive runtime evidence will be appended to the task record as the programme continues.