Skip to content

fix(actionbar): preserve cooldown state across relog - #33

Merged
blakinio merged 17 commits into
mainfrom
fix/OTC-20260726-actionbar-cooldown-lifecycle
Jul 26, 2026
Merged

fix(actionbar): preserve cooldown state across relog#33
blakinio merged 17 commits into
mainfrom
fix/OTC-20260726-actionbar-cooldown-lifecycle

Conversation

@blakinio

Copy link
Copy Markdown
Owner

Purpose

Repair the confirmed action-bar cooldown lifecycle defect where protocol cooldown packets can be missed or erased before UI construction, visual preferences suppress cache updates, and button rebuilds stop restored overlays.

Task

Scope

  • module-lifetime cooldown subscriptions
  • synchronous session cache reset at correct boundaries
  • cache-first packet handling independent of visual options
  • maximum individual/group remaining-time restoration
  • common restoration path for text spells, runes and multi-actions
  • focused Lua lifecycle tests

Safety

  • no protocol payload, Canary, hotkey mapping or persisted action schema changes
  • existing ActionBarController and widgets remain authoritative
  • draft until dependencies, exact-head CTest and required Windows CI pass

@blakinio
blakinio marked this pull request as ready for review July 26, 2026 09:54
@blakinio
blakinio force-pushed the fix/OTC-20260726-actionbar-cooldown-lifecycle branch from f234137 to 8e69cd8 Compare July 26, 2026 09:54
@blakinio
blakinio enabled auto-merge (squash) July 26, 2026 09:54
@blakinio
blakinio merged commit c6a5532 into main Jul 26, 2026
14 checks passed
@blakinio
blakinio deleted the fix/OTC-20260726-actionbar-cooldown-lifecycle branch July 26, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant