You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Finish OTC-20260816-linux-ci-hybrid post-merge validation without re-enabling Windows.
Evidence driving this follow-up
PR #331 is already merged and its exact-head CI run 31935503532 passed both hosted Linux matrix jobs, the real release-artifact Xvfb startup smoke, and CI / Required.
The first compile-scope push on main (31937211914, merge SHA c4b1919e16fb2931c74f32cb310229703dbf893c) failed during vcpkg dependency installation because the freetype 2.14.3 source endpoint returned HTTP 504 through all three built-in download attempts. Setup, workflow validation and earlier dependencies succeeded; this was not an OTClient compile diagnostic. A same-SHA rerun reached both Run CMake jobs but was intentionally cancelled when newer documentation-only main commits superseded the old run via the repository concurrency policy.
allow the current task to own .github/workflows/reusable-build-linux.yml;
cache only vcpkg/downloads using pinned actions/cache v6.1.0;
keep the existing CMake action as the primary attempt;
if that attempt fails, retry the same pinned configure/build action exactly once;
preserve all existing Linux tests, artifact upload, headless startup smoke and CI / Required semantics.
Failure semantics
The first CMake attempt uses continue-on-error only to permit the bounded second attempt. A second failure remains a normal job failure, so deterministic code/configuration failures are not converted to success.
Boundaries
Windows general CI remains disabled.
No Synology/Track A runtime workflow is changed.
No production source, runtime asset, protocol, repository setting or physical gameplay behavior is changed.
vcpkg/downloads contains source/tool downloads, not OTClient runtime state or built client artifacts.
Validation contract
Before merge require on the exact PR head:
workflow/actionlint validation;
Linux release build;
Linux tests build plus unit/Lua/integration tests;
real release-artifact Client Startup Smoke - Linux under Xvfb;
CI / Required success.
After merge require a fresh compile-scope main run with the same Linux build/smoke/Required chain. Only then archive OTC-20260816-linux-ci-hybrid and release ownership.
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.
that exact head and squash merge c4b1919e16fb2931c74f32cb310229703dbf893c have the identical tree 6a51b91962c61b72a97a308d07292779ac7c3407;
the failed post-merge attempt is directly attributable to repeated HTTP 504 responses while vcpkg fetched freetype from gitlab.freedesktop.org, not an OTClient compile diagnostic;
The proposed vcpkg/downloads cache + bounded CMake retry may be considered later as a separate CI-resilience optimization, but it should not reopen this completed hybrid-routing task or bundle the unrelated stale OTC-20260712-client-test-foundation cleanup. No review thread or owner decision requires this PR to remain open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Finish
OTC-20260816-linux-ci-hybridpost-merge validation without re-enabling Windows.Evidence driving this follow-up
PR #331 is already merged and its exact-head CI run
31935503532passed both hosted Linux matrix jobs, the real release-artifact Xvfb startup smoke, andCI / Required.The first compile-scope push on
main(31937211914, merge SHAc4b1919e16fb2931c74f32cb310229703dbf893c) failed during vcpkg dependency installation because the freetype 2.14.3 source endpoint returned HTTP 504 through all three built-in download attempts. Setup, workflow validation and earlier dependencies succeeded; this was not an OTClient compile diagnostic. A same-SHA rerun reached bothRun CMakejobs but was intentionally cancelled when newer documentation-onlymaincommits superseded the old run via the repository concurrency policy.Changes
OTC-20260712-client-test-foundationownership now that PR test: establish client unit and integration test foundation #3 is merged;.github/workflows/reusable-build-linux.yml;vcpkg/downloadsusing pinnedactions/cachev6.1.0;CI / Requiredsemantics.Failure semantics
The first CMake attempt uses
continue-on-erroronly to permit the bounded second attempt. A second failure remains a normal job failure, so deterministic code/configuration failures are not converted to success.Boundaries
vcpkg/downloadscontains source/tool downloads, not OTClient runtime state or built client artifacts.Validation contract
Before merge require on the exact PR head:
Client Startup Smoke - Linuxunder Xvfb;CI / Requiredsuccess.After merge require a fresh compile-scope
mainrun with the same Linux build/smoke/Required chain. Only then archiveOTC-20260816-linux-ci-hybridand release ownership.Primary implementation: #331.
Task:
OTC-20260816-linux-ci-hybrid.