Skip to content

docs(task): archive character list recreation #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blakinio merged 1 commit into from
Jul 26, 2026
Merged

docs(task): archive character list recreation #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions .../OTC-20260726-characterlist-recreation.md → .../OTC-20260726-characterlist-recreation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
---
task_id: OTC-20260726-characterlist-recreation
coordination_id: ""
status: in_progress
status: complete
agent: "GPT-5.6 Thinking"
branch: fix/OTC-20260726-characterlist-recreation
base_branch: main
created: 2026-07-26T00:46:58+02:00
updated: 2026-07-26T11:00:00+02:00
last_verified_commit: "e9061b680331233d2153e0f3afb2fd78b7f9aaa1"
updated: 2026-07-26T11:49:01+02:00
last_verified_commit: "5accfca40a2d66802d73fab069cd284b836c22ef"
risk: medium
related_issue: "opentibiabr/otclient#1775 (character-list relog subcase)"
related_pr: "#31"
Expand Down Expand Up @@ -44,7 +44,7 @@ Make the legacy and Oteryn character-list layouts safely reusable after the list
- [x] UI load failure is nil-safe and restores the enter-game window instead of indexing a nil widget.
- [x] Legacy `characterlist.otui` and Oteryn `oteryn_characterlist.otui` use the same controller path.
- [x] Focused Lua tests cover default, custom, absolute, root-resolving, missing-layout and repeated recreation decisions.
- [ ] Runtime-root Lua syntax and required CI pass on the exact final head.
- [x] Runtime-root Lua syntax and required CI pass on the exact final head.
- [x] Full changed-file list and diff are reviewed before squash merge.

# Confirmed context
Expand Down Expand Up @@ -106,12 +106,12 @@ Make the legacy and Oteryn character-list layouts safely reusable after the list

| Commit | Check | Result | Evidence |
|---|---|---|---|
| `841031a129c3148e425de819abe907d8bc3f2e32` | root-resolving layout regression | pending | focused CTest suite |
| `e9061b680331233d2153e0f3afb2fd78b7f9aaa1` | `luajit tests/lua/helpers/runner.lua tests/lua/unit/characterlist_lifecycle_test.lua tests/lua/unit/characterlist_lifecycle_adapter_test.lua` | passed | 10 focused tests, 0 failed, using the repository Windows vcpkg LuaJIT |
| `e9061b680331233d2153e0f3afb2fd78b7f9aaa1` | `git diff --check` | passed | no whitespace errors |
| pending final head | Runtime Lua syntax | pending | required CI |
| pending final head | Windows CMake Tests / CTest | pending | required CI |
| pending final head | `CI / Required` | pending | final merge gate |
| `5accfca40a2d66802d73fab069cd284b836c22ef` | Runtime Lua syntax | passed | run `30195023839`, `Lua Syntax / Check Lua Syntax` |
| `5accfca40a2d66802d73fab069cd284b836c22ef` | Windows CMake Tests / CTest | passed | run `30195023839`, `Build - Windows / Compile (CMake Tests)` |
| `5accfca40a2d66802d73fab069cd284b836c22ef` | required Windows build matrix | passed | run `30195023839`: CMake Release, CMake Tests, Solution DirectX, Solution OpenGL and Solution Debug |
| `5accfca40a2d66802d73fab069cd284b836c22ef` | `CI / Required` | passed | exact-head aggregate in run `30195023839` |

# Risks and compatibility

Expand All @@ -123,19 +123,17 @@ Make the legacy and Oteryn character-list layouts safely reusable after the list

# Remaining work

1. Pass exact-head required CI/CTest.
2. Verify reviews and stable base, then squash-merge.
3. Archive this task.
None.

# Handoff

Open this task and PR #31, then inspect `characterlist_lifecycle*.lua`, `entergame.otmod` and both focused Lua tests. Do not duplicate CharacterList login/population logic or introduce a second controller.

# Completion

- Final status: in progress
- Final status: complete
- PR: #31
- Merge commit: pending
- Merge commit: `a9a03b88c14ee0d5d7b61332ca83f464b5b670e8`
- Catalogue updated: not applicable; no public reusable interface
- Changelog updated: yes
- Archived at: pending
- Archived at: 2026-07-26T11:49:01+02:00
Loading