fix(track-a): accept XRes returned client resource base - #461
Merged
blakinio merged 4 commits intoAug 17, 2026
Merged
Conversation
blakinio
marked this pull request as ready for review
August 17, 2026 09:50
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
blakinio
enabled auto-merge (squash)
August 17, 2026 09:50
blakinio
deleted the
fix/OTC-20260816-track-a-canonical-runtime-xres-client-base
branch
August 17, 2026 09:52
This was referenced Aug 17, 2026
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track A canonical RUNTIME — hosted XRes client-base helper correction
Task:
OTC-20260816-track-a-canonical-runtime-e2eBase: trusted
main@c55e3523e6e9d50df511e65dce9145a8f951a5f5after physical identity #457 and archive #459.This is a GitHub-hosted-only follow-up for
XRES-V2-AUD-001. It performs no Synology/X11/official-client/canonical-state access and authorizes no physical retry.The retained v2 physical reply proved that QueryClientIds for resource
0x00c00011may return owning client resource-base0x00c00000with LocalClientPid13648. The persistent helper incorrectly required the returned client identifier to echo the exact queried resource XID.Correction:
exactly one recordfail-closed cardinality;LocalClientPidmask;Expected deterministic suite after this change: 37 tests. Dedicated helper validation must remain transport-free. After protected promotion, downstream P0 work still requires its own fresh RUNTIME admission and may proceed only if a legal current IN_GAME lifecycle exists; no session bootstrap solely for P0 is authorized.