feat(surveyor): add action protocol typed reader - #645
Merged
blakinio merged 11 commits intoAug 21, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Implement
OTC-20260821-surveyor-action-protocol-reader, the highest-value non-overlapping Surveyor typed-reader gap after the completed auth/session slice.Current physical baseline: 169 rows / 12 aliases / 9 missing readers / privacy PASS.
world_minimap_typed_readerremains rank 1 but overlaps active #475/#593, so this slice selects rank-2action_protocol_typed_reader.Reader boundary
The reader exact-fences the current official client, derives the exact current
tibia::game::TPlayerProtocolMessageHandlerprimary vptr from RTTI/relative relocations, and proves exactly one typed live object through boundedO_RDONLYprocess-memory observation. It emits onlyTYPED_ACTION_PROTOCOL_OBJECT_IDENTITY_ONLYand explicitly does not claim action-to-protocol linkage, serialized message semantics, opcodes, packet payloads or IN_GAME state.The implementation also centralizes Surveyor reader registration so later typed-reader slices do not require duplicating runtime dispatch logic.
Safety
No login/relogin, credentials, GUI/gameplay input, process control, attach/debug/injection, memory writes, client/container restart, target-network mutation, item/economy action or local-model use is authorized.
Expected repository-only gap count after implementation: 8. Physical post-merge read-only acceptance remains required before task archive/closeout.