Skip to content

refactor(options): own inventory reload scheduling - #93

Merged
blakinio merged 5 commits into
mainfrom
refactor/OTC-20260729-options-phase1-native-migration
Jul 30, 2026
Merged

refactor(options): own inventory reload scheduling#93
blakinio merged 5 commits into
mainfrom
refactor/OTC-20260729-options-phase1-native-migration

Conversation

@blakinio

@blakinio blakinio commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Purpose

Continue merged PR #36 by removing the temporary global scheduleEvent/removeEvent interception from the Phase 0 compatibility adapter.

Delivered scope

  • keep canonical showExpiryInInventory and legacy showExpiryInInvetory as one adapter-owned value;
  • preserve canonical-precedence startup migration and dual settings writes;
  • schedule inventory reload directly under adapter ownership;
  • suppress raced stale callbacks and cancel only the preceding adapter-owned reload on rapid changes and during termination;
  • preserve existing widget normalization and hidden unsupported controls;
  • prove unrelated scheduling/removal is untouched;
  • register the focused options Lua test as its own CTest target;
  • document the hardening in the agent changelog after the shared-path lease was released.

Current-main reconciliation

PR #92 released the changelog lease, and PR #94 archived its separate W6 task. This branch was rebuilt on exact current main commit 4e09e32032e64831c30d6f7aeb31a2ebd4d4520a; its five changed paths do not overlap the #94 archive paths.

Validation

Final exact-head Windows CMake/CTest and repository required CI are pending on the rebuilt branch. Earlier runs were intentionally superseded when main advanced.

Safety

Legacy client Lua/test registration and agent documentation only. No authentication, protocol, renderer, Canary, server, proprietary asset or greenfield Rust runtime changes.

Task

OTC-20260729-options-phase1-native-migration

@blakinio blakinio changed the title refactor(options): retire Phase 0 runtime adapter refactor(options): own inventory reload scheduling Jul 29, 2026
@blakinio
blakinio marked this pull request as ready for review July 29, 2026 21:48
@blakinio blakinio closed this Jul 29, 2026
@blakinio
blakinio force-pushed the refactor/OTC-20260729-options-phase1-native-migration branch from 9127e9c to 3cea444 Compare July 29, 2026 22:12
@blakinio blakinio reopened this Jul 29, 2026
@blakinio blakinio closed this Jul 29, 2026
@blakinio
blakinio force-pushed the refactor/OTC-20260729-options-phase1-native-migration branch from 15c5e19 to 4e09e32 Compare July 29, 2026 22:28
@blakinio blakinio reopened this Jul 29, 2026
@blakinio
blakinio enabled auto-merge (squash) July 30, 2026 08:16
@blakinio
blakinio merged commit bdb73ee into main Jul 30, 2026
22 of 24 checks passed
@blakinio
blakinio deleted the refactor/OTC-20260729-options-phase1-native-migration branch July 30, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant