Expose observer reconcilers via public pkg/controller aliases - #138
Merged
Conversation
Same convention already used for the domain reconcilers
(pkg/controller/{environments,events,networks,sources}) — a thin
public alias so environments-tests has a legal, non-internal import
path to construct these against. The observer reconcilers
(build/buildrun/githubevent/gitrepository/deployment/environment)
had none, which made their behavior (GitHubEvent-triggered Build
annotation patching, retry bookkeeping, etc.) unreachable from the
conformance suite despite being live, wired code.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg/controller/observers/{build,buildrun,githubevent,gitrepository,deployment,environment}— thin public type aliases pointing at the existinginternal/controller/observers/*reconcilers, same convention already used for the domain reconcilers (pkg/controller/{environments,events,networks,sources}).Why
The observer layer (GitHubEvent→Build trigger mirroring, retry bookkeeping, BuildRun/Sensor/Kustomization/Repository status reflection) is live, wired code with zero test coverage anywhere. It was unreachable from
environments-testsspecifically because it had no non-internal/import path — this closes that gap so the conformance suite can drive these reconcilers the same way it already does forBuildReconciler/GitHubEventReconciler.Test plan
go build ./...cleango vet ./...cleanenvironments-testsagainst this branch, to follow🤖 Generated with Claude Code