feat: add 'hermes node restart' command + token reload on bind#96
Merged
Conversation
Three changes: 1. runner.start() now always reads the token from disk first. Generates a fresh one only when the file is missing/empty AND we own the port. Manual edits to ~/.hermes/nodes-internal-token are picked up on next restart without a gateway restart. 2. POST /admin/restart endpoint drains and restarts the WSS server in-place. WebSocket connections are closed during drain. Authenticated via the internal token. 3. 'hermes node restart' CLI command POSTs to /admin/restart, reads the current token from the shared file to authenticate. Flow: edit token file -> hermes node restart -> server reads it. Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
hermes node restart— POSTs to/admin/restart, drains and restarts the WSS server in-place~/.hermes/nodes-internal-tokenon everystart()How it works
~/.hermes/nodes-internal-tokenhermes node restartChanged files
wsserver/server.py—POST /admin/restartendpoint (auth-gated)lifecycle.py— token read-before-generate logic; store runner on app.statecli.py—restartsubcommand +_cmd_restartimplementation