fix: rotating log for auto-start, quiet stdout#98
Merged
Conversation
Two bugs: 1. Server: _verify_internal_auth cached the token in app.state at startup. If the token file was overwritten later (auto-start in another process), server and CLI disagreed -> 401 -> hermes node list silently showed all nodes as disconnected. Now reads ~/.hermes/nodes-internal-token on every request via new _read_token_from_disk() helper. Uses hmac.compare_digest. 2. CLI/tools: _connected_names and _node_list_impl silently swallowed auth errors. _connected_names now returns set[str] | None; None means "cannot query". 401/403 print a clear stderr warning. _cmd_list shows a warning banner and marks rows as "unknown" instead of "disconnected". New state constant: STATE_UNKNOWN. Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
- Replace print()+append with RotatingFileHandler (5 MB cap, 1 backup) - Only print lifecycle events to stdout (server started, failures, errors) - Routine diagnostics go to file only (port checks, thread lifecycle, etc.) - Remove stale import urllib.error (missed in #97) Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92 and improves it:
Changes
RotatingFileHandler— 5 MB cap, 1 backup. File auto-rotates instead of growing forever.All routine diagnostics (port checks, config loaded, daemon thread started, event loop closed, etc.) go to file only.
import urllib.error(missed in fix: read internal token from disk per-request, surface auth errors #97).