chore: remove dead code (functions, error classes, unused params)#99
Merged
Conversation
- Remove dead functions: _resolve_registry, _connection_summary (tools.py), run_server (wsserver/server.py + shims) - Remove dead error classes: AuthError, NodeNotConnectedError, NodeExecutionError, NodeReadError (errors.py) - Remove unused params: args in _cmd_status/_cmd_restart (cli.py), registry in 4 impl functions (tools.py) - Remove phantom reset_default_runner docstring references (lifecycle.py) - Remove unused TYPE_CHECKING imports (tools.py) Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all dead code found during review.
Removed
_resolve_registry,_connection_summary(tools.py),run_server(wsserver/server.py + shims)AuthError,NodeNotConnectedError,NodeExecutionError,NodeReadError— remnants from deleted NodeEnvironmentargsin_cmd_status/_cmd_restart,registryin 4 impl functionsreset_default_runnerdocstring mentions (never defined)-158 lines, all tests pass, ruff clean.