bb-block production: allow the Apps Platform control-plane host - #332
Open
nathan-thillairajah wants to merge 1 commit into
Open
nathan-thillairajah wants to merge 1 commit into
nathan-thillairajah wants to merge 1 commit into
Conversation
morgmart
reviewed
Sep 16, 2026
morgmart
left a comment
Collaborator
There was a problem hiding this comment.
🤖 Automated code review
COMMENT: The exact PR comparison cleanly adds the bb-block production control-plane hostname to the existing exact-host HTTPS allowlist and adds discriminating acceptance and rejection coverage. No concrete implementation findings remain. All 11 supplied GitHub check runs completed successfully, although required checks independently govern merge readiness. Architecture ownership of the newly trusted credential recipient needs Morgan's decision.
Deterministic publication result: 0 blocking and 0 non-blocking inline finding(s) publishable; 0 duplicate(s) suppressed; 0 blocking screenshot-evidence requirement(s) in this review body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI rejects the bb-block production Apps Platform ingress before making a request. Add
compose-ctrl.block.builderlab.xyzto the exact control-plane allowlist so the existing BBIdentity authentication and app lifecycle commands can reach production.Extend the existing allowlist test to cover the production origin, explicit port 443, and rejection of HTTP, lookalike domains, other ports, userinfo, and app hosts. The existing chat and agent laws are unaffected.
Validation: 51 Apps Platform tests passed, rustfmt passed, and a local
bbbuild successfully authenticated, fetched the production contract, created a test app, deployed its baseline version, and confirmed exact-version readiness. Browser consent and provider-tool execution have not yet been verified.