build: update Node.js to 24.21.0 and align CI toolchains - #965
Merged
Merged
Conversation
Move the hermit-managed dev/CI Node from 24.15.0 to 24.21.0 (current 24.x LTS): bin/.node-24.15.0.pkg -> bin/.node-24.21.0.pkg, with the node/npm/npx/corepack shims retargeted. No other hermit package changes; the shipped runtime pin (node-runtime.lock.json) is left for a separate commit. Drop the `corepack enable pnpm` steps from the five workflows that use pnpm (staged-ci, staged-release, differ-ci, penpal-ci, penpal-release). Hermit already puts a standalone pnpm 10.33.0 on PATH, matching the `packageManager` field, so the step adds nothing. Worse, under the hermit PATH `corepack` resolves to bin/corepack, so `corepack enable` overwrote hermit's bin/pnpm symlink with a corepack shim that re-downloaded the same pnpm from the registry on every CI run. Node >= 25 no longer ships corepack, so the step would also break the upcoming Node 26 move. Add `bin/**` to the push and pull_request path filters of staged-ci, differ-ci and penpal-ci so a hermit toolchain bump triggers CI instead of merging untested. Verified on Node 24.21.0: pnpm install --frozen-lockfile; staged build, check (3392 files, 0 errors) and vitest (81 files, 1118 tests); differ check (3993 files, 0 errors) and build; penpal frontend vitest (25 files, 257 tests). No other references to Node 24.15 exist in the repo. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
Move the Node runtime that Staged downloads onto users' machines to run the ACP bridges (@agentclientprotocol/claude-agent-acp, codex-acp) from v24.11.0 to v24.21.0, the current 24.x LTS, matching the hermit dev/CI Node bumped in 6e7523b. node-runtime.lock.json was regenerated with `just bump-node-runtime v24.21.0`; the same four target triples are pinned and every sha256 was cross-checked against the official https://nodejs.org/dist/v24.21.0/SHASUMS256.txt (the recipe reads the checksum file through the Artifactory mirror). On next launch users download the new runtime (~55 MiB) and both bridges are reinstalled under it. The reconciler keeps the old runtime until the new one installs successfully and only then prunes it, and both bridges accept Node >= 22, so a plain revert rolls this back. Also refresh the stale comments next to the pin: the MAX_ARCHIVE_BYTES note now reflects the largest pinned tarball (linux-x64, ~55 MiB; the old "~49 MB" was the darwin-arm64 size) and the two "e.g. v24.11.0" examples in the lock struct doc and the bump script cite the current pin. Verified: cargo test managed_node in apps/staged/src-tauri, 15 passed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
crates-ci.yml runs through cashapp/activate-hermit, so cargo, rustfmt, clippy and just all resolve via the hermit symlinks in bin/ (bin/.rustup-*.pkg, bin/.just-*.pkg), but its paths filters only watched rust-toolchain.toml. A hermit rustup or just bump could therefore merge without running the crates checks. Add "bin/**" to both the pull_request and push filters, matching what 6e7523b did for staged-ci, differ-ci and penpal-ci. Also update the bump-node-runtime recipe comment in apps/staged/justfile from `v24.12.0` to `v24.21.0` so the example matches the current node-runtime.lock.json pin and the other "e.g." examples refreshed in 174535f. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
🤖 Generated with Claude Code