Add just design to open the design-system viewer - #115
Merged
Merged
Conversation
Signed-off-by: morgmart <98432065+morgmart@users.noreply.github.com>
morgmart
marked this pull request as ready for review
September 22, 2026 00:44
morgmart
requested review from
a team,
comp615 and
wesbillman
as code owners
September 22, 2026 00:44
wesbillman
reviewed
Sep 22, 2026
wesbillman
left a comment
Collaborator
There was a problem hiding this comment.
Carl, an automated reviewer, commenting via Wes’s GitHub account.
No actionable findings. Reviewed head 1f0cac17813d08e3cbc1b1e93786f80c082e1b50 against base b49b6e3a03de6100cb7127c2ec785f276e480c65.
- The five-line recipe is appropriately scoped: it reuses the locked-install dependency and existing positional-argument convention, then invokes the existing design viewer. The documentation matches its configuration: port 1442, strict port conflicts, and the viewer-specific browser-opening path. This command selects the standalone config rather than the main app’s live-broker config.
- Independently checked the complete diff and command/config/viewer entry path. The exact-head extracted justfile passes command listing and default/alternate-port dry runs with pinned just 1.58.0; exact base-to-head
git diff --checkpasses. These were source/dry-run checks, not a local server or browser run. The PR reports actual default/alternate-port, occupied-port, opener-URL and Ctrl+C checks; I did not independently repeat them. Visible OS browser launch remains unverified. - Hosted JavaScript, browser measurements, DCO, Semgrep and zizmor checks pass. Rust/tool integration and four browser journey shards are still running; Windows native validation is skipped. Required human/code-owner approval remains outstanding. Those are merge/validation gates, not defects identified in this diff.
Posting a comment, not formal approval. No merge performed.
wesbillman
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Adds
just designto start the existing design-system viewer and open it in your browser. It installs locked dependencies like the other development commands, without starting the desktop app or live relay broker.Why it matters
The design system now has a short, discoverable command alongside
just webandjust desktop. Both existing commands stay unchanged.How it works
Reuses the existing viewer's server and browser-opening configuration, with the argument-forwarding pattern from #109. The default port is 1442; use
just design --port 1444when it is occupied. The README and contribution guide document the command and Ctrl+C shutdown.Verification