Conversation
Co-authored-by: Amp <amp@ampcode.com> Signed-off-by: Charlie Croom <ccroom@squareup.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a0a149-b278-7550-acc4-356168b0c4b5
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI-authored implementation and description.
Stacked on #81, independent of #83. Moves semantic permutations to their component/service owners while retaining browser-specific and end-to-end integration coverage. No production changes.
Coverage mapping (8 browser cases removed / 16 engine executions; 6 mounted cases added):
The installed notification-producer/disable/OS-click-to-Settings journey remains: isolated service navigation is not equivalent to that integration. All sidebar geometry and cross-window unread cases remain.
Negative controls: breaking membership filtering, stale completion fencing and notification deduplication triggered failures during migration. Additional controls disabled Settings subscription (both mounted cases failed) and made an earlier mention trigger incorrectly win over emoji (both channel/reply cases failed). All temporary production mutations were restored.
Current local checks: full Vitest 149 files / 1,558 tests passed; affected retained browser files plus mentions integration passed 58/58 in Chromium/WebKit. TypeScript, Biome, diff checks and pre-push passed. Local timings are not a CI speedup claim.
Hosted results compare unchanged #81 with this candidate. Runner/worker configuration is unchanged. Full gate means earliest job start through required-gate completion, excluding queue time.
Both candidate gates passed, with 378 browser executions and exactly the planned 16 removals from the 394-execution baseline. No failures, skips or retries. The changed files saved roughly 35–36s of summed WebKit test work in each run, but they ran on the faster shard. The repeat also sped up untouched files and spent longer in setup, so its improvement cannot be attributed solely to this migration.
There is no consistent full-gate speedup demonstrated: one run was 35s slower than the fresh baseline and one 26s faster. This improves test layering and removes redundant browser work, but is not a proven large CI-latency win. Human/code-owner review is still required. #83 and this branch combine without conflicts, but no combined runtime benchmark has been run; their savings must not be added together.