fix(desktop): separate Nostr name from display name - #3342
Conversation
Profile settings screenshotsBefore — Buzz v0.5.0The supported Profile editor exposes only After — PR #3342The same editor exposes an independent Nostr |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cec957d304
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bdc5880479
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
8b89f7f to
02e127c
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02e127c8c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Vitor Cepeda Lopes <vitor@vitorcepedalopes.com>
Signed-off-by: Vitor Cepeda Lopes <vitor@vitorcepedalopes.com>
Signed-off-by: Vitor Cepeda Lopes <vitor@vitorcepedalopes.com>
Signed-off-by: Vitor Cepeda Lopes <vitor@vitorcepedalopes.com>
02e127c to
3211052
Compare
Signed-off-by: Vitor Cepeda Lopes <vitor@vitorcepedalopes.com>
3211052 to
abeeb06
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: abeeb060a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Vitor Cepeda Lopes <vitor@vitorcepedalopes.com>
Signed-off-by: Vitor Cepeda Lopes <vitor@vitorcepedalopes.com>


Summary
name/handle alongside the richerdisplay_namein first-community onboarding and Profile settingsRelated issue
Fixes #2796
Related preservation work: #2534, #2545, #2606.
Root cause
Buzz Desktop labels the onboarding value as a username but publishes it as
display_name. The supported UI has no independentnamefield, even though existing metadata can contain one. The prior update path also reconstructed a modeled subset of kind-0 metadata, which could discard unrelated fields while adding the missing editor.This patch treats
nameanddisplay_nameas independent metadata and updates the existing raw JSON object before signing the replacement kind-0 event. Compatibility fallback fromdisplay_nametonameis limited to presentation boundaries, including sidebar, identity lookup, profile activity, and fallback agent-session labels.User impact
Users can represent a short Nostr handle separately from their human-facing display name without changing keys, roles, authentication, relay admission, or NIP-05. Existing display-name-only and name-only profiles remain compatible, and editing one modeled field preserves the other fields.
Testing
Fresh post-rebase evidence at
abeeb060aagainstupstream/main63496cc1d:git diff --check upstream/main...HEADCHECK_FILE_SIZES_BASE=upstream/mainnamenameThe pre-rebase branch also passed the complete
just desktop-cigate, focused Rust profile tests, and four focused Playwright profile/onboarding tests. Fresh GitHub checks on the rebased branch are the authority for the full current snapshot.The patch is currently
test_provenfor the Desktop frontend and focused profile paths. It does not claim supported-path runtime or end-to-end signed-event proof.Manual test plan
nameanddisplay_namevalues.nameis shown instead ofAgent.Non-goals