fix(acp): default subscribe=all excludes typing/presence (#3649) - #3675
Open
NanoRisk6 wants to merge 1 commit into
Open
fix(acp): default subscribe=all excludes typing/presence (#3649)#3675NanoRisk6 wants to merge 1 commit into
NanoRisk6 wants to merge 1 commit into
Conversation
) BUZZ_ACP_SUBSCRIBE=all with no BUZZ_ACP_KINDS was a full wildcard, so typing (20002) and presence (20001) woke the agent every keystroke — token burn and a false "agent is typing" badge. Use a durable allowlist by default; explicit kinds override still wins. Signed-off-by: NanoRisk6 <aidashtherapy@gmail.com>
NanoRisk6
force-pushed
the
cat/acp-subscribe-all-exclude-ephemeral-3649
branch
from
July 30, 2026 03:50
c56c8f6 to
6901ade
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
With
BUZZ_ACP_SUBSCRIBE=alland noBUZZ_ACP_KINDS, the agent subscribed to every kind. Typing indicators (20002) and presence (20001) each started an agent turn — token burn per keystroke and a false Desktop “agent is typing” badge while the human typed. Fixes #3649.Why This Change Was Made
Mentions mode already ships a curated default kinds list. All mode used
kinds: None(NIP-01 wildcard).Default for All (when kinds override is unset) is now a durable allowlist:
Ephemeral kinds (typing, presence, observer frames) are not included.
BUZZ_ACP_KINDS=…still fully overrides (operators can re-add 20002 if they really want it).Same default applied in
resolve_dynamic_channel_filterfor late-joined channels.User Impact
Agents on
subscribe=allrespond to real channel work without paying a model call for every keystroke, and Desktop no longer shows the agent “typing” while the human composes.Evidence