Skip to content

fix: align responsive agent views #3688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
klopez4212 merged 2 commits into from
Jul 30, 2026
+223 −44
Merged

fix: align responsive agent views #3688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5eda7a
fix: align responsive agent views
klopez4212 Jul 30, 2026
b324405
fix: preserve agent defaults focus
klopez4212 Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 93 additions & 31 deletions desktop/src/features/agents/ui/AgentsView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from "react";
import { OctagonX, Settings2 } from "lucide-react";
import { EllipsisVertical, OctagonX, Settings2 } from "lucide-react";
import {
consumePendingSnapshotImport,
subscribeSnapshotImport,
Expand All @@ -20,10 +20,7 @@ import { SecretRevealDialog } from "./SecretRevealDialog";
import { TeamDeleteDialog } from "./TeamDeleteDialog";
import { TeamDialog } from "./TeamDialog";
import { TeamsSection } from "./TeamsSection";
import {
AGENT_CARD_GRID_COLUMNS_CLASS,
UnifiedAgentsSection,
} from "./UnifiedAgentsSection";
import { UnifiedAgentsSection } from "./UnifiedAgentsSection";
import { useManagedAgentActions } from "./useManagedAgentActions";
import { usePersonaActions } from "./usePersonaActions";
import { useTeamActions } from "./useTeamActions";
Expand All @@ -32,6 +29,12 @@ import { useBakedBuildEnvQuery } from "@/features/agents/hooks";
import { isManagedAgentActive } from "@/features/agents/lib/managedAgentControlActions";
import { useGlobalAgentConfig } from "@/features/agents/useGlobalAgentConfig";
import { Button } from "@/shared/ui/button";
import {
DropdownMenu,
DropdownMenuContent,
DropdownMenuItem,
DropdownMenuTrigger,
} from "@/shared/ui/dropdown-menu";
import { PageHeader } from "@/shared/ui/PageHeader";
import { getInheritedAgentDefaults } from "./bakedEnvHelpers";

Expand All @@ -44,6 +47,8 @@ export function AgentsView() {
const personas = usePersonaActions();
const teamImportInputRef = React.useRef<HTMLInputElement | null>(null);
const aiDefaultsTriggerRef = React.useRef<HTMLButtonElement>(null);
const fullAiDefaultsTriggerRef = React.useRef<HTMLButtonElement>(null);
const compactActionsTriggerRef = React.useRef<HTMLButtonElement>(null);
const [isAiDefaultsOpen, setIsAiDefaultsOpen] = React.useState(false);
// Exclusivity: create never sets `personaDialogState` (edit/dup/import do),
// so the create-mode and definition-edit AgentDialog mounts never coexist.
Expand All @@ -53,6 +58,22 @@ export function AgentsView() {
personas.prepareCreate();
setIsCreateDialogOpen(true);
}

function openAiDefaults(trigger: HTMLButtonElement | null) {
aiDefaultsTriggerRef.current = trigger;
setIsAiDefaultsOpen(true);
}

function setAiDefaultsDialogOpen(open: boolean) {
if (!open) {
aiDefaultsTriggerRef.current =
fullAiDefaultsTriggerRef.current?.offsetParent !== null
? fullAiDefaultsTriggerRef.current
: compactActionsTriggerRef.current;
}
setIsAiDefaultsOpen(open);
}

const teamActions = useTeamActions(
{
setActionNoticeMessage: agents.setActionNoticeMessage,
Expand Down Expand Up @@ -113,43 +134,84 @@ export function AgentsView() {
<>
<div className="flex-1 overflow-y-auto overflow-x-hidden overscroll-contain px-4 py-7 sm:px-6 sm:py-8">
<div
className={`mx-auto grid w-full max-w-6xl ${AGENT_CARD_GRID_COLUMNS_CLASS} justify-start gap-x-3 gap-y-8`}
className="mx-auto w-full max-w-6xl space-y-8 [container-type:inline-size]"
data-testid="agents-page-content"
>
<PageHeader
className="col-[1/-1]"
action={
<div className="flex flex-wrap justify-end gap-2">
<Button
data-testid="agent-defaults-button"
ref={aiDefaultsTriggerRef}
onClick={() => setIsAiDefaultsOpen(true)}
size="sm"
variant="outline"
>
<Settings2 />
{hasSavedAgentDefaults
? "Agent defaults"
: "Set agent defaults"}
</Button>
{runningAgentCount > 0 ? (
<>
<div className="flex flex-wrap justify-end gap-2 [@container(max-width:40rem)]:hidden">
<Button
disabled={isActionPending}
onClick={() => {
void agents.handleBulkStopRunning();
}}
data-testid="agent-defaults-button"
ref={fullAiDefaultsTriggerRef}
onClick={(event) => openAiDefaults(event.currentTarget)}
size="sm"
variant="outline"
>
<OctagonX />
Stop running agents
<Settings2 />
{hasSavedAgentDefaults
? "Agent defaults"
: "Set agent defaults"}
</Button>
) : null}
</div>
{runningAgentCount > 0 ? (
<Button
disabled={isActionPending}
onClick={() => {
void agents.handleBulkStopRunning();
}}
size="sm"
variant="outline"
>
<OctagonX />
Stop running agents
</Button>
) : null}
</div>

<DropdownMenu modal={false}>
<DropdownMenuTrigger asChild>
<Button
aria-label="Agent actions"
className="hidden [@container(max-width:40rem)]:inline-flex"
data-testid="agent-actions-menu-trigger"
ref={compactActionsTriggerRef}
size="icon"
type="button"
variant="outline"
>
<EllipsisVertical />
</Button>
</DropdownMenuTrigger>
<DropdownMenuContent align="end">
<DropdownMenuItem
onSelect={() => {
openAiDefaults(compactActionsTriggerRef.current);
}}
>
<Settings2 />
{hasSavedAgentDefaults
? "Agent defaults"
: "Set agent defaults"}
</DropdownMenuItem>
{runningAgentCount > 0 ? (
<DropdownMenuItem
disabled={isActionPending}
onSelect={() => {
void agents.handleBulkStopRunning();
}}
>
<OctagonX />
Stop running agents
</DropdownMenuItem>
) : null}
</DropdownMenuContent>
</DropdownMenu>
</>
}
description="Set up and manage your agents."
title="Agents"
/>
<div className="col-[1/-1] flex flex-col gap-8">
<div className="flex flex-col gap-8">
<UnifiedAgentsSection
defaultModel={inheritedDefaults.model.value}
actionErrorMessage={agents.actionErrorMessage}
Expand Down Expand Up @@ -238,7 +300,7 @@ export function AgentsView() {
</div>

<AgentDefaultsDialog
onOpenChange={setIsAiDefaultsOpen}
onOpenChange={setAiDefaultsDialogOpen}
open={isAiDefaultsOpen}
returnFocusRef={aiDefaultsTriggerRef}
/>
Expand Down
6 changes: 3 additions & 3 deletions desktop/src/features/agents/ui/TeamsSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ import { IdentityCardSkeleton } from "@/shared/ui/identity-card-skeleton";
import { SectionHeader } from "@/shared/ui/PageHeader";
import { CreateIdentityCard } from "./CreateIdentityCard";
import { TeamIdentityCard } from "./TeamIdentityCard";
import { IDENTITY_CARD_GRID_CLASS } from "./UnifiedAgentsSection";

const TEAM_CARD_COLUMN_CLASS = "w-full";
const TEAM_CARD_GRID_CLASS = `${TEAM_CARD_COLUMN_CLASS} mx-auto grid max-w-[996px] grid-cols-[repeat(auto-fill,minmax(220px,240px))] justify-center gap-3`;

type TeamsSectionProps = {
teams: AgentTeam[];
Expand Down Expand Up @@ -63,7 +63,7 @@ export function TeamsSection({
</div>

{isLoading ? (
<div className={TEAM_CARD_GRID_CLASS}>
<div className={IDENTITY_CARD_GRID_CLASS}>
<IdentityCardSkeleton
footerSubtitleWidthClass="w-14"
footerTitleWidthClass="w-24"
Expand All @@ -83,7 +83,7 @@ export function TeamsSection({
) : null}

{!isLoading ? (
<div className={TEAM_CARD_GRID_CLASS}>
<div className={IDENTITY_CARD_GRID_CLASS}>
{teams.map((team) => {
const resolution = resolveTeamPersonas(team, personas);
const missingPersonaCount = resolution.missingPersonaCount;
Expand Down
8 changes: 4 additions & 4 deletions desktop/src/features/agents/ui/UnifiedAgentsSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ type UnifiedAgentsSectionProps = {
const AGENT_CARD_COLUMN_CLASS = "w-full";
export const AGENT_CARD_GRID_COLUMNS_CLASS =
"grid-cols-[repeat(auto-fill,minmax(220px,240px))]";
const AGENT_CARD_GRID_CLASS = `${AGENT_CARD_COLUMN_CLASS} ${AGENT_CARD_GRID_COLUMNS_CLASS} grid justify-start gap-3`;
export const IDENTITY_CARD_GRID_CLASS = `${AGENT_CARD_COLUMN_CLASS} ${AGENT_CARD_GRID_COLUMNS_CLASS} grid justify-start gap-3 [@container(max-width:40rem)]:justify-center`;

export function UnifiedAgentsSection(props: UnifiedAgentsSectionProps) {
const {
Expand Down Expand Up @@ -153,7 +153,7 @@ export function UnifiedAgentsSection(props: UnifiedAgentsSectionProps) {

{!isLoading ? (
<div className="space-y-3" data-testid="unified-agents-groups">
<div className={AGENT_CARD_GRID_CLASS}>
<div className={IDENTITY_CARD_GRID_CLASS}>
{groups.map((group) => {
const profileAgent = pickProfileAgent(group.agents);
return (
Expand Down Expand Up @@ -479,7 +479,7 @@ function NewAgentCard({

function LoadingSkeleton() {
return (
<div className={AGENT_CARD_GRID_CLASS}>
<div className={IDENTITY_CARD_GRID_CLASS}>
<IdentityCardSkeleton
footerSubtitleWidthClass="w-14"
footerTitleWidthClass="w-24"
Expand Down Expand Up @@ -537,7 +537,7 @@ function CollapsibleAgentGroup({
<span className="text-xs text-muted-foreground">({agents.length})</span>
</button>
{!isCollapsed ? (
<div className={AGENT_CARD_GRID_CLASS}>
<div className={IDENTITY_CARD_GRID_CLASS}>
{agents.map((agent) => (
<StandaloneAgentCard
agent={agent}
Expand Down
Loading
Loading