fix(desktop): add opencode to default_agent_args for ACP support - #3706
Open
Chukwuebuka-2003 wants to merge 1 commit into
Open
fix(desktop): add opencode to default_agent_args for ACP support#3706Chukwuebuka-2003 wants to merge 1 commit into
Chukwuebuka-2003 wants to merge 1 commit into
Conversation
The default_agent_args function was missing the opencode command, so when a user selects the OpenCode harness without specifying custom arguments, the agent launches without the required 'acp' argument. This caused the ACP initialize to time out after 60 seconds. Fixes block#3660 Signed-off-by: Chukwuebuka-2003 <ebulamicheal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
default_agent_argsfunction was missing theopencodecommand identity. When a user selects the built-in OpenCode harness without specifying custom arguments, the agent launches without the requiredacpargument. This causes the ACP initialize to time out after 60 seconds.Fixes #3660
Root cause
default_agent_argsindesktop/src-tauri/src/managed_agents/discovery.rsmaps command names to their default ACP arguments. OpenCode needs["acp"]like Goose, but it was not listed — sonormalize_agent_argsreturned an empty arg list when no user-defined args were stored on the record.Normalization path when args are empty and no custom harness definition exists:
Fix
Added
"opencode" => Some(vec!["acp".to_string()])todefault_agent_args.Testing