Skip to content

fix(workflow): separate owner attribution from mentions - #3716

Open
skyerus wants to merge 1 commit into
block:mainfrom
skyerus:fix/workflow-owner-actor-tag
Open

fix(workflow): separate owner attribution from mentions#3716
skyerus wants to merge 1 commit into
block:mainfrom
skyerus:fix/workflow-owner-actor-tag

Conversation

@skyerus

@skyerus skyerus commented Jul 30, 2026

Copy link
Copy Markdown

Fixes #3638.

What changed

  • use the existing relay-trusted actor tag for workflow-owner attribution
  • reserve p tags for members explicitly mentioned in message content
  • keep explicit mentions of the workflow owner notifying normally (actor + p)
  • extract message-tag construction into a pure helper with focused regression coverage

Why

Workflow ownership is provenance, while p tags are notification recipients and agent wake targets. Using the owner as an implicit p recipient caused every workflow-generated card to notify or wake its owner even when the rendered message contained no mention.

Buzz already has the right native primitive: relay-signed delegated events use actor for attribution, and Desktop resolves that actor as the effective author. This change uses that existing path rather than introducing a new tag or workflow option.

Verification

  • cargo fmt --all -- --check
  • workspace Clippy with all targets/features and warnings denied
  • cargo test -p buzz-relay --lib workflow_sink — 19 passed, 1 ignored
  • cargo test -p buzz-relay --lib workflow_send_message_separates_actor_from_mentioned_member -- --ignored --nocapture — passed against PostgreSQL
  • cargo test -p buzz-workflow — 153 passed, 2 ignored

Workflow ownership is provenance, but p tags also trigger notifications and agent wake-up. Use Buzz's relay-trusted actor tag for the owner so only explicit textual mentions become notification recipients.

Co-authored-by: Skye Gill <gill.skye95@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus
skyerus requested a review from a team as a code owner July 30, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Workflow owner p-tag wakes the owner agent on every send_message

1 participant