fix(desktop): strip Windows extended-path prefix before git clone - #3717
Open
JoeJoeflyn wants to merge 1 commit into
Open
fix(desktop): strip Windows extended-path prefix before git clone#3717JoeJoeflyn wants to merge 1 commit into
JoeJoeflyn wants to merge 1 commit into
Conversation
…ock#3707) Signed-off-by: JoeJoeflyn <thaitainguyen336@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PathBuf::canonicalize()on Windows returns paths with the\\?\extended-length prefix, which Git for Windows rejects withInvalid argumentdunce::simplified()to strip the prefix at the two git CLI boundaries before passing paths to gitFixes #3707
Testing
cargo test --lib -- project_repo_pathspassescargo clippy --libclean