IT[TcpBrokerConnectionIT]: fix port collision, refactor - #125
Merged
678098 merged 1 commit intoAug 27, 2026
Conversation
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
678098
commented
Aug 26, 2026
| final TestTcpServer[] servers = | ||
| new TestTcpServer[] { | ||
| new BmqBrokerSimulator(opts.brokerUri().getPort(), Mode.BMQ_AUTO_MODE), | ||
| BmqBrokerContainer.createContainer(opts.brokerUri().getPort()) |
Collaborator
Author
There was a problem hiding this comment.
These 2 servers were using the same port.
There were no guarantee that the async server stop will be triggered fast enough to let the second server get the port.
So the fix is to construct different ConnectionOptions for these 2 servers.
Also, possible to get rid of the array and for-loop by having 2 calls
Contributor
|
Looks like this is related to message properties v1, which will be removed very soon too. |
chrisbeard
approved these changes
Aug 27, 2026
Collaborator
Author
Yes. Currently it blocks CI in dependabot PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConnectionOptions(no port reuse)forloop, have 2 calls insteadFixes the following IT flakiness:
[ERROR] Errors: [ERROR] com.bloomberg.bmq.it.TcpBrokerConnectionIT.testNegotiationMpsEx [ERROR] Run 1: TcpBrokerConnectionIT.testNegotiationMpsEx:626 » InternalServerError Status 500: {"message":"failed to set up container networking: driver failed programming external connectivity on endpoint bmq-broker-java-it45675 (b9ca11a29b8354259f0a9d216886dfa4df6fdbe5f44ed1218de0d8b45562f3d7): failed to bind host port for 0.0.0.0:45675:172.17.0.3:30114/tcp: address already in use"}