Skip to content

Fix: CloseQueueStrategy leaks queue on failed close-request write #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
678098 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix: CloseQueueStrategy leaks queue on failed close-request write #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion bmq-sdk/src/main/java/com/bloomberg/bmq/impl/CloseQueueStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,17 @@ private void handleConfigureStatus(StatusCategory confStatusCategory) {

if (genericResult.isFailure()) {
logger.error("Failed to send closeQueue request. RC={}", genericResult);
setQueueState(QueueState.e_CLOSED);
if (scenario.isDefault()) {
// If no connection the queue now is closed.
onFullyClosed();
if (genericResult.isNotConnected()) {
genericResult = GenericResult.SUCCESS;
}

@678098 678098 Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to startSequence
https://github.com/678098/blazingmq-sdk-java/blob/e4687173c47bad35d88870c2c6aabee79d4a487c/bmq-sdk/src/main/java/com/bloomberg/bmq/impl/CloseQueueStrategy.java#L161-L169

} else {
// The late scenarios have already removed the queue from the
// active maps, so just mark it closed (mirrors onCloseResponse()).
setQueueState(QueueState.e_CLOSED);
}

resultHook(genericResult);
}
Expand Down
17 changes: 7 additions & 10 deletions bmq-sdk/src/test/java/com/bloomberg/bmq/impl/BrokerSessionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1254,7 +1254,9 @@ void closeQueueRequestFailsTest() {

obj.sendConfigureStreamResponse(configureRequest);

assertEquals(CloseQueueResult.NOT_CONNECTED, closeFuture.get(FUTURE_TIMEOUT));
// With no connection the queue is considered closed, so close
// reports success.
assertEquals(CloseQueueResult.SUCCESS, closeFuture.get(FUTURE_TIMEOUT));

// Check close request
obj.verifyCloseQueueRequest(true);
Expand All @@ -1266,21 +1268,16 @@ void closeQueueRequestFailsTest() {

// Check event
obj.verifyQueueControlEvent(
QueueControlEvent.Type.e_QUEUE_CLOSE_RESULT, CloseQueueResult.NOT_CONNECTED);
QueueControlEvent.Type.e_QUEUE_CLOSE_RESULT, CloseQueueResult.SUCCESS);

assertEquals(QueueState.e_CLOSED, queue.getState());

// Open the queue
obj.connection().resetWriteStatus(); // SUCCESS

// Due to the bug, queue is not closed fully, so we cannot reopen it
logger.info("[BUG] Current queue cannot be reopened");
assertEquals(
OpenQueueResult.QUEUE_ID_NOT_UNIQUE,
queue.open(queueOptions, SEQUENCE_TIMEOUT));

// Create and open another queue
queue = obj.createQueue(createUri(), flags);
// The queue is fully closed and no longer registered in the active
// queue map, so the same queue can be reopened.
assertNull(obj.queueManager().findByQueueId(queue.getFullQueueId()));

obj.openQueue(queue, queueOptions);

Expand Down
Loading