Redact SASL response from Connection Start-Ok trace logging - #94
Merged
Conversation
`ConnectionStartOk::operator<<` serialized the SASL `response` field. This can contain credentials which should never be logged. Redact it. The `response` is opaque, mechanism-defined data, so it is redacted unconditionally. `properties`, `mechanism` and `locale` are unchanged, and the `response()` accessor is untouched. Add coverage: - `rmqamqpt`: `operator<<` emits `response:<REDACTED>`, not the response - `rmqamqp`: a mocked handshake captures logs and asserts no credentials
michalovits
approved these changes
Aug 28, 2026
Rahmeen14
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConnectionStartOk::operator<<serialized the SASLresponsefield. This can contain credentials which should never be logged. Redact it.The
responseis opaque, mechanism-defined data, so it is redacted unconditionally.properties,mechanismandlocaleare unchanged, and theresponse()accessor is untouched.Add coverage:
rmqamqpt:operator<<emitsresponse:<REDACTED>, not the responsermqamqp: a mocked handshake captures logs and asserts no credentials