[PW_SID:1152789] [v1,1/2] Bluetooth: SCO: require CAP_NET_BIND_SERVICE to bind - #657
[PW_SID:1152789] [v1,1/2] Bluetooth: SCO: require CAP_NET_BIND_SERVICE to bind#657BluezTestBot wants to merge 7 commits into
Conversation
This patch adds workflow files for ci: [sync.yml] - The workflow file for scheduled work - Sync the repo with upstream repo and rebase the workflow branch - Review the patches in the patchwork and creates the PR if needed [ci.yml] - The workflow file for CI tasks - Run CI tests when PR is created Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
This replaces the bzcafe action with bluez/action-ci so we can maintain everything in the github bluez organization Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This attempts to sync every 5 minutes instead of 30. Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
bluez/action-ci uses master as default branch for workflow which is incorrect for kernel Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
The CI action now creates individual GitHub Check Runs per test, which requires 'checks: write' permission on the GITHUB_TOKEN. Also make the pull_request trigger types explicit to include 'reopened', allowing CI to be retriggered by closing and reopening a PR.
SCO sockets have no PSM or port namespace: binding one simply reserves the ability to accept any incoming eSCO/SCO connection on the adapter. That is equivalent to listening on a well-known service, which L2CAP already restricts to CAP_NET_BIND_SERVICE in l2cap_validate_bredr_psm()/l2cap_validate_le_psm(). Apply the same restriction to sco_sock_bind() so unprivileged processes can no longer hijack incoming SCO links. Fixes: 1da177e ("Linux-2.6.12-rc2") Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
ISO sockets have no PSM or port namespace: binding one reserves the ability to accept any incoming CIS or to sync to broadcast streams on the adapter. That is equivalent to listening on a well-known service, which L2CAP already restricts to CAP_NET_BIND_SERVICE in l2cap_validate_bredr_psm()/l2cap_validate_le_psm(). Apply the same restriction to iso_sock_bind() so unprivileged processes can no longer hijack incoming ISO links. Fixes: ccf74f2 ("Bluetooth: Add BTPROTO_ISO socket type") Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
|
CheckPatch |
|
VerifyFixes |
|
VerifySignedoff |
|
GitLint |
|
SubjectPrefix |
|
BuildKernel |
|
CheckAllWarning |
|
CheckSparse |
|
BuildKernel32 |
|
CheckKernelLLVM |
|
TestRunnerSetup |
|
TestRunner_iso-tester |
|
TestRunner_sco-tester |
|
IncrementalBuild |
3 participants
From: Luiz Augusto von Dentz luiz.von.dentz@intel.com
SCO sockets have no PSM or port namespace: binding one simply reserves
the ability to accept any incoming eSCO/SCO connection on the adapter.
That is equivalent to listening on a well-known service, which L2CAP
already restricts to CAP_NET_BIND_SERVICE in
l2cap_validate_bredr_psm()/l2cap_validate_le_psm().
Apply the same restriction to sco_sock_bind() so unprivileged processes
can no longer hijack incoming SCO links.
Fixes: 1da177e ("Linux-2.6.12-rc2")
Signed-off-by: Luiz Augusto von Dentz luiz.von.dentz@intel.com
net/bluetooth/sco.c | 7 +++++++
1 file changed, 7 insertions(+)