Repository navigation
Fix code-review findings from the migrate apply queueing change - #20
Merged
Merged
Conversation
- Lock tqdm bar.update()/bar.write() calls: both the worker thread and
the --ask review loop call into the same tqdm instance, which isn't
guaranteed thread-safe without an explicit lock.
- Warn (instead of silently treating every file as pending) when the
tracking table is missing on apply, matching migrate check's behavior.
- Fix the CREATE TABLE regex fallback to stop at '(' as well as
whitespace, so `CREATE TABLE foo(id int)` parses as `foo` instead of
`foo(id`, which was making apply wrongly report a successful
migration as failed verification.
Bump version to 0.3.4.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MsW4bjEgHHQKvmCReYzyNg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CREATE TABLE foo(id int)parses asfooinstead offoo(id, which was making apply wrongly report a successful migration as failed verification.Bump version to 0.3.4.
Claude-Session: https://claude.ai/code/session_01MsW4bjEgHHQKvmCReYzyNg