Conversation
pgdb testdb's "permissions files apply last" guarantee doesn't transfer to a forward-only production migration runner, which applies each file exactly once, ever, as whatever role it connects as -- a recurring real-world bug class (see bmsuisse/PgMigrator#31307). Points at execute_sql_script/created_table_names/missing_privileges (added in #39) as the primitives for building a guard against it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
aersam
marked this pull request as ready for review
September 28, 2026 20:57
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs-only follow-up to #39. Adds guidance to
docs/database-layout.mdandREADME.mdexplaining thatpgdb testdb's "permissions files apply last, genuinely" guarantee is specific to howensure_testdb()re-derives the whole schema every run -- a production apply path built onpgdevkit.migrate(forward-only, each file runs exactly once, as whatever shared role connects) doesn't get that guarantee for free. Points atexecute_sql_script/created_table_names/missing_privileges(added in #39) as the primitives for building a guard against it, referencing the real incident this generalizes from (bmsuisse/PgMigrator#31307, ADO work item #30294).No code changes -- CI won't run (README.md/docs are in
paths-ignore), and there's no version bump since nothing published changes.Test plan
🤖 Generated with Claude Code
Claude Session: eb39e5a4-58aa-5f93-8d7b-8c71961197aa