Skip to content

Improve AppImage compatibility and update support - #49

Closed
boggedbrush wants to merge 3 commits into
mainfrom
codex/appimage-catalog-compatibility
Closed

boggedbrush wants to merge 3 commits into
mainfrom
codex/appimage-catalog-compatibility

Conversation

@boggedbrush

Copy link
Copy Markdown
Owner

Summary

  • Build the Linux AppImage on Ubuntu 22.04 to target older supported distributions.
  • Repack the Electron-generated AppImage with GitHub Releases zsync update information.
  • Verify the embedded update information and generated .zsync asset in CI.

Changes are limited to .github/workflows/linux-build.yml.

Validation

  • Parsed the workflow YAML.
  • Checked the embedded Bash step with bash -n.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-27T22:49:55.434349Z ba08183 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ba08183e8b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

PYTHON_VERSION: "3.12"
APPIMAGE_PATH: dist/packages/PatchOpsIII.AppImage
ZSYNC_PATH: dist/packages/PatchOpsIII.AppImage.zsync
APPIMAGE_UPDATE_INFO: gh-releases-zsync|boggedbrush|PatchOpsIII|latest|PatchOpsIII.AppImage.zsync

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use matching update metadata for beta artifacts

When this reusable workflow is called by the beta pipeline (release-beta.yml:304-310), it embeds the stable asset name PatchOpsIII.AppImage.zsync, but the publishing job renames that file to PatchOpsIII-Beta.AppImage.zsync (release-beta.yml:462-466). Consequently, a published beta AppImage cannot discover its beta zsync asset using the embedded metadata; pass channel-specific update information or keep the published asset name consistent.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Superseded by #50, which carries the AppImage compatibility and update work with verified packaging tools, channel-specific update metadata, and CI coverage. Closing this PR to keep review focused on #50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant