Repository navigation
feat: add native GPUI desktop alternative for stack evaluation - #52
boggedbrush wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52b8d2150d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .child( | ||
| Button::new("refresh") | ||
| .label(if self.busy { "Working…" } else { "Refresh" }) | ||
| .disabled(self.busy) |
There was a problem hiding this comment.
When the confirmation panel is open, Refresh remains enabled because this check ignores self.pending. Clicking it starts a status request and sets busy; if Confirm is clicked before that request finishes, the pending operation is removed and send immediately returns because the view is busy. The UI then says the operation is running even though it was never queued. Disable refresh while a confirmation is pending, disable confirmation while busy, or retain the pending request until it is successfully sent.
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
1 participant
Purpose
Add a runnable native Rust/GPUI alternative to evaluate alongside the current Electron app and Tauri alternatives (#36 and #40). The branch starts from current main and replaces the UI/runtime with native controls while reusing the existing Python operations, allowing a controlled first renderer comparison.
Implementation
Validation
Passed locally on Linux:
tsc --noEmit), archive contents, and process-tree sampler smoke checks.Evaluation boundaries
This is an experimental evaluation slice, not full production parity. Python remains required; the ZIPs do not bundle its runtime. Logs are polled rather than streamed. Signed installers, updater integration, detailed depot UX, and hardware/accessibility validation remain follow-up gates. No comparative performance win is claimed; the measurement plan accounts for the entire process tree and backend/package differences from #40.
Windows/Wayland/Steam Deck and actual game-file/mod-install workflows need the documented manual checks. Automatic approval review blocked a GUI Apply-click smoke check as potentially file-changing; no game-mutating UI actions were executed in this environment. Confirmation behavior was reviewed in code. Hosted CI results are separate from the local validation above.