fix: replace walrus operator for Python 3.6 compatibility#78
Merged
Conversation
…compatibility The walrus operator (:=) was introduced in Python 3.8. Replace it with a traditional two-line assignment to maintain compatibility with Python 3.6 and 3.7 as declared in setup.py classifiers. Fixes #77
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
The walrus operator (
:=) was introduced in Python 3.8. The project declares support for Python 3.6 and 3.7 in setup.py classifiers, but the walrus operator atbuilder.py:684would break on those versions.Why This Change Was Made
Replace the walrus operator with a traditional two-line assignment pattern — an
elseblock with an explicitif m:check. This is functionally identical but compatible with Python 3.6+.User Impact
Users on Python 3.6 and 3.7 can now use luaparser without hitting a syntax error.
Evidence
Fixes #77