fix: replace distutils with setuptools, modernize Python support#5
Open
boolangery wants to merge 2 commits into
Open
fix: replace distutils with setuptools, modernize Python support#5boolangery wants to merge 2 commits into
boolangery wants to merge 2 commits into
Conversation
- Replace distutils imports with setuptools equivalents: - distutils.command.sdist → setuptools.command.sdist - distutils.command.build_ext → setuptools.command.build_ext - distutils.cmd.Command → setuptools.Command - Update Python version classifiers from 3.6/3.7 to 3.8-3.12 - Add python_requires='>=3.8' distutils was removed in Python 3.12, causing import errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
py-lua-style uses
distutilswhich was removed in Python 3.12. This causes import errors:distutils.command.sdistdistutils.command.build_extdistutils.cmd.CommandAdditionally, the Python version classifiers only listed 3.6 and 3.7, which are long EOL.
Fix
distutilsimports withsetuptoolsequivalentspython_requires='>=3.8'*.htmlto.gitignorefor Cython annotation filesTesting
python3-devsystem package for C extension compilation (installed on CI)